MasmARMCompiler: Report MSVC-like argument syntax #15198
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
armasmis quite stripped-down in terms of supported features compared to its cousinml64, but I think it makes sense to report'msvc'as the argument syntax. Currently theCompiler.get_argument_syntax()vfunc is not overriden and the base implementation returns'other'. This in turn causes the ninja backend to emit themasm_COMPILERrule withdeps = gccwhich causes some issues: https://github.com/mesonbuild/meson/blob/1.9.1/mesonbuild/backend/ninjabackend.py#L2649-L2654Of course there are other ways to fix the issue, let me know what you think about this :)
See https://gitlab.gnome.org/GNOME/glib/-/issues/3814