Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment: Read VALAC from the environment and use it if set #1851

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

alvarez86
Copy link
Contributor

The valac binary was hard coded in meson. We now check if VALAC is
defined in the environment, and if it is, use its value as the vala
compiler, if not, we proceed with the hard coded binary name.

This is meant for #1645, I don't really know how to provide a test case for this, as it will
require two vala compilers in the environment. Nonetheless, I hope this will be useful,
even as a starting point.

The valac binary was hard coded in meson. We now check if VALAC is
defined in the environment, and if it is, use its value as the vala
compiler, if not, we proceed with the hard coded binary name.
@codecov-io
Copy link

codecov-io commented May 25, 2017

Codecov Report

Merging #1851 into master will increase coverage by 7.98%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
+ Coverage   62.99%   70.98%   +7.98%     
==========================================
  Files          58       75      +17     
  Lines       16870    23261    +6391     
  Branches     3452     6290    +2838     
==========================================
+ Hits        10628    16511    +5883     
- Misses       5149     5573     +424     
- Partials     1093     1177      +84
Impacted Files Coverage Δ
mesonbuild/environment.py 82.45% <100%> (+11.16%) ⬆️
mesonbuild/dependencies/misc.py 52.92% <0%> (-0.84%) ⬇️
mesonbuild/dependencies/__init__.py 100% <0%> (ø) ⬆️
mesonbuild/scripts/dist.py 0% <0%> (ø) ⬆️
mesonbuild/scripts/meson_install.py 0% <0%> (ø) ⬆️
mesonbuild/backend/xcodebackend.py 0% <0%> (ø) ⬆️
mesonbuild/modules/qt4.py 0% <0%> (ø) ⬆️
mesonbuild/scripts/vcstagger.py 0% <0%> (ø) ⬆️
mesonbuild/modules/rpm.py 0% <0%> (ø) ⬆️
mesonbuild/modules/modtest.py 100% <0%> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe84a6f...9941632. Read the comment docs.

@oleavr
Copy link
Contributor

oleavr commented May 25, 2017

This is also covered by #1808.

@jpakkane
Copy link
Member

Since the issue will be fixed by #1808, let's close this.

@nirbheek
Copy link
Member

nirbheek commented Aug 9, 2017

Since #1808 is not going to be ready in time for the release, we should probably merge this for now. I think it's a small enough change that won't break anything so close to the release.

@nirbheek nirbheek reopened this Aug 9, 2017
@nirbheek
Copy link
Member

nirbheek commented Aug 9, 2017

<al_t> yes, this is needed for getting vala itself built with meson. bootstrap and i think running the test suite as well

Looks like we have a pretty good reason for doing it now rather than later. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants