Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qrencode: add 4.1.1 #1277

Merged
merged 2 commits into from
Nov 10, 2023
Merged

qrencode: add 4.1.1 #1277

merged 2 commits into from
Nov 10, 2023

Conversation

hrxi
Copy link
Contributor

@hrxi hrxi commented Nov 5, 2023

No description provided.

@neheb
Copy link
Collaborator

neheb commented Nov 5, 2023

weird that clang-cl builds but not cl...

@hrxi
Copy link
Contributor Author

hrxi commented Nov 6, 2023

It's a problem of missing __declspec(dllexport), I believe.

@neheb
Copy link
Collaborator

neheb commented Nov 6, 2023

Yeah need to add a def file.

They're needed to make MSVC export symbols from DLLs.
@hrxi
Copy link
Contributor Author

hrxi commented Nov 10, 2023

Also opened an upstream PR fixing MSVC support properly: fukuchi/libqrencode#214.

@neheb neheb merged commit d6c1261 into mesonbuild:master Nov 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants