taocpp-json: add taoJSON version 1.0.0-beta.14 #1705
Conversation
rherilier
force-pushed
the
add-taocpp-json
branch
2 times, most recently
from
616423d
to
9f6b37b
Compare
|
I opened #1706 to handle dashes in version strings |
releases.json
Outdated
| @@ -3436,6 +3436,14 @@ | |||
| "1.12-1" | |||
| ] | |||
| }, | |||
| "taocpp-json": { | |||
| "dependency_names": [ | |||
| "taocpp_json" | |||
There was a problem hiding this comment.
The upstream dependency name is taocpp-json, with a dash not an underscore!
There was a problem hiding this comment.
my bad, I mimic howabseil-cpp was defined to make taocpp-json's files. So, I thought that dependency were the symbol defined in the provide section of wrap file...
There are many other entries with dependencies in the usual meaning too.
So, I looked inreleases.json and found that many entries have no dependency_names node, (such catch or mocklibc). Does it imply that the wrap name is implicitly used as a dependency?
Can you help me clarifying this point?
There was a problem hiding this comment.
my bad, I mimic how
abseil-cppwas defined to make taocpp-json's files. So, I thought that dependency were the symbol defined in the provide section of wrap file...
They are, indeed, the symbol defined in the provide section of the wrap file.'
For example, abseil-cpp provides the dependency symbol:
/usr/lib64/pkgconfig/absl_base.pc
and hence uses "absl_base" in its provide section.
Similarly, taocpp-json provides taocpp-json-config.cmake, and hence should list "taocpp-json" in the wrap releases, to annotate the fact that the provide section has been fixed to provide "taocpp-json".
and found that many entries have no dependency_names node, (such catch or mocklibc).
They are very old and buggy.
There was a problem hiding this comment.
thanks you for the clarification
| taocpp_json_dep = declare_dependency( | ||
| include_directories: [taocpp_json_inc] | ||
| ) |
There was a problem hiding this comment.
The upstream CMakeLists.txt depends on PEGTL, why doesn't this?
There was a problem hiding this comment.
taocpp-json is header-only, PEGTL is only required for tests.
There was a problem hiding this comment.
What does "header-only" have to do with it? How is someone expected to utilize taocpp-json if PEGTL is not installed and checked for?
There was a problem hiding this comment.
not my day... all my assumptions are based on the Debian's package which has not been updated for 4 years, and at that time, taoJSON embedded PEGTL.
rherilier
force-pushed
the
add-taocpp-json
branch
from
9f6b37b
to
c167a7e
Compare
I can add it if it is mandatory. If so, do I have to add examples and performance programs too? |
rherilier
force-pushed
the
add-taocpp-json
branch
from
c167a7e
to
4ec751d
Compare
No description provided.