zlib-ng: add #1710
Open
zlib-ng: add #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! |
This seems like a place that the wrap infrastructure could be enhanced, there are likely more cases where a dependency can be provided by multiple upstreams. Not saying you have to do this, just noting it. |
Based on zlib.wrap and zlib-ng's CMake build.
The wrap omits these upstream features:
- Support for building without optimizations (WITH_OPTIM=OFF), with
-march=native (WITH_NATIVE_INSTRUCTIONS=ON), without new strategies,
without runtime CPU detection, or with reduced memory requirements
- Support for building as C99
- Configurable API function name prefix
- Forcible override of optimization levels greater than 2, enablement of
-fno-semantic-interposition, and use of software floating point on
32-bit ARM. It's not the build system's job to override the user's
settings. We do forcibly disable LTO to prevent it potentially merging
blocks built for different CPU subarches. (GCC, at least, won't do that
in any case.)
- Defining HAVE_SYMVER (optional, and currently a no-op)
- Defining ZLIB_DEBUG in debug builds. Wrap users probably don't want
this.
- Naming the static build "zlibstatic" on Windows
- Maintainer warnings
- Sanitizers, fuzzers, benchmarks, coverage, and most tests
Also, the exact build logic differs from upstream in a number of small
details.
The wrap always uses the dependency name "zlib-ng", even when building in
zlib-compat mode. Meson will not allow zlib and zlib-ng to share the
dependency name "zlib" within WrapDB. Parent projects can invoke
meson.override_dependency('zlib', ...) if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
zlib.wrapand zlib-ng's CMake build.The wrap omits these upstream features:
WITH_OPTIM=OFF), with-march=native(WITH_NATIVE_INSTRUCTIONS=ON), without new strategies, without runtime CPU detection, or with reduced memory requirements-fno-semantic-interposition, and use of software floating point on 32-bit ARM. It's not the build system's job to override the user's settings. We do forcibly disable LTO to prevent it potentially merging blocks built for different CPU subarches. (GCC, at least, won't do that in any case.)HAVE_SYMVER(optional, and currently a no-op)ZLIB_DEBUGin debug builds. Wrap users probably don't want this.zlibstaticon WindowsAlso, the exact build logic differs from upstream in a number of small details.
The wrap always uses the dependency name
zlib-ng, even when building in zlib-compat mode. Meson will not allow zlib and zlib-ng to share the dependency namezlibwithin WrapDB. Parent projects can invokemeson.override_dependency('zlib', ...)if desired.