provide sqlite2cpp as well

[vpoinot]

The script sqlite2cpp works better than ddl2cpp when it comes to sqlite3 schemas. Provide it as well.

[jpakkane]

You need to add the package to releases.json.

[vpoinot]

You need to add the package to releases.json.

Is this https://github.com/mesonbuild/wrapdb/pull/1786/files#diff-f71e67b61c52ecd942c6d915f8ff111cb57052fe82992eda958b87a9c62ed633R3469 not enough?

[jpakkane]

It is not. You need to add a new entry in the version list as well. "0.64-2"

[vpoinot]

It is not. You need to add a new entry in the version list as well. "0.64-2"

Done: https://github.com/mesonbuild/wrapdb/pull/1786/files#diff-f71e67b61c52ecd942c6d915f8ff111cb57052fe82992eda958b87a9c62ed633R3473

Let me know if something else is needed.

[vpoinot]

The sanity checks fail on macos, because of some missing dependency (mariadb). Is this something expected?

[jpakkane]

Maybe brew has changed their packaging somehow? I don't use macOS, so not really sure how to debug that. If nothing else then the flag should be removed from ci_config.json.

[eli-schwartz]

wrapdb/ci_config.json

Lines 1076 to 1085 in 4972deb

	"sqlitecpp": {
	"_comment": "required to not use the default sqlite3 in MacOS to avoid compilation errors/tests failures, also add pkgconfig path to find sqlite3(keg-only)",
	"build_options": [
	"sqlitecpp:SQLITECPP_BUILD_TESTS=true",
	"sqlitecpp:SQLITECPP_BUILD_EXAMPLES=true",
	"pkg_config_path=/usr/local/opt/sqlite/lib/pkgconfig"
	],
	"brew_packages": [
	"sqlite"
	]

If mariadb is mandatory for the wrapdb CI e.g. in order to run all tests, then please install it in the ci config. It's possible this wasn't necessary in the past because GitHub chose to install it by default -- they sometimes remove packages that most people don't use in order to decrease VM sizes for their hosted runners. IIRC they have done one of those cleanups recently.

[eli-schwartz]

Please use git commit --fixup=sha1 && git rebase -i --autosquash when fixing issues introduced in a previous commit in the same PR.

[vpoinot]

Please use git commit --fixup=sha1 && git rebase -i --autosquash when fixing issues introduced in a previous commit in the same PR.

I have run git commit --fixup=63562a5ee0e9cbc86e99e2c76d24caf0b1f98e80 && git rebase -i --autosquash, but I am not sure that it did anything...

[jpakkane]

Rebasing against current master should make the error go away.

[vpoinot]

Rebasing against current master should make the error go away.

Nope, my branch is already up-to-date.

[jpakkane]

If I click on the branch link that page says "This branch is 5 commits ahead of, 27 commits behind mesonbuild/wrapdb:master."