Skip to content

sdl3_image: add hidden visibility #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sdl3_image: add hidden visibility #2468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab66b6
Functions are currently failing to link when building with meson
xoSauce May 25, 2025
a69ddfc
sdl3_image: add hidden visibility
neheb Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions releases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3932,6 +3932,7 @@
"sdl3_image"
],
"versions": [
"3.2.4-2",
"3.2.4-1"
]
},
Expand Down
34 changes: 26 additions & 8 deletions subprojects/packagefiles/sdl3_image/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,21 @@
project('sdl3_image', 'c',
version: '3.2.4')
project(
'sdl3_image',
'c',
license: 'zlib',
version: '3.2.4',
meson_version: '>=0.54.0',

Check notice on line 6 in subprojects/packagefiles/sdl3_image/meson.build

View workflow job for this annotation

GitHub Actions / Ubuntu (x86_64)

Minimum Meson version is 0.54.0 

0.48.0: gnu_symbol_visibility arg in library
0.50.0: include_directories kwarg of type string
0.54.0: meson.override_dependency
)

sdl_dep = dependency('sdl3', version: '>=3.2.4')
sdl_dep = dependency(
'sdl3',
version: '>=3.2.4',
)

png_dep = dependency('libpng')
jpg_dep = dependency('libjpeg', required: false)
jpg_dep = dependency(
'libjpeg',
required: false,
)

img_args = []

Expand All @@ -15,11 +26,18 @@
#endif

subdir('src')
img_lib = library('sdl3_image',
img_lib = library(
'sdl3_image',
img_src,
c_args: img_args,
include_directories: 'include',
dependencies: [png_dep, sdl_dep])
gnu_symbol_visibility: 'hidden',
dependencies: [png_dep, sdl_dep],
)

sdl3_image_dep = declare_dependency(include_directories: 'include',
link_with: img_lib)
sdl3_image_dep = declare_dependency(
include_directories: 'include',
link_with: img_lib,
)

meson.override_dependency('sdl3_image', sdl3_image_dep)
3 changes: 2 additions & 1 deletion subprojects/packagefiles/sdl3_image/src/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
img_src = files(
'IMG.c',
'IMG_WIC.c',
'IMG_avif.c',
'IMG_bmp.c',
'IMG_gif.c',
Expand All @@ -14,7 +16,6 @@ img_src = files(
'IMG_tga.c',
'IMG_tif.c',
'IMG_webp.c',
'IMG_WIC.c',
'IMG_xcf.c',
'IMG_xpm.c',
'IMG_xv.c',
Expand Down
2 changes: 1 addition & 1 deletion subprojects/sdl3_image.wrap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ source_hash = a725bd6d04261fdda0dd8d950659e1dc15a8065d025275ef460d32ae7dcfc182
patch_directory = sdl3_image

[provide]
sdl3_image = sdl3_image_dep
dependency_names = sdl3_image
Loading