create_release: add patch_fallback_url; point source_fallback_url at nginx
#2532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch_url points to a redirect on wrapdb.mesonbuild.com, which is convenient if we ever want to add additional mirrors or if we have to move off of GitHub. However, it also means wraps will fail to build if wrapdb.mesonbuild.com goes down, unless the patch is already cached locally. Avoid this by adding a patch_fallback_url pointing directly to the GitHub download.
source_fallback_url points directly at the source mirror in the GitHub release, which means we can't retroactively add additional mirrors or move existing releases off of GitHub. Instead, point it to the new get_source API endpoint on wrapdb.mesonbuild.com. This (re-)introduces a failure mode if wrapdb.mesonbuild.com goes down, but only in the fallback path when the canonical source URL is unavailable. That seems like a worthwhile trade for the added flexibility.
Collaborator
Author
|
This requires the config changes in #2521 to be deployed. Edit: done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch_urlpoints to a redirect onwrapdb.mesonbuild.com, which is convenient if we ever want to add additional mirrors or if we have to move off of GitHub. However, it also means wraps will fail to build ifwrapdb.mesonbuild.comgoes down, unless the patch is already cached locally. Avoid this by adding apatch_fallback_urlpointing directly to the GitHub download.Conversely,
source_fallback_urlpoints directly at the source mirror in the GitHub release, which means we can't retroactively add additional mirrors or move existing releases off of GitHub. Instead, point it to the newget_sourceAPI endpoint onwrapdb.mesonbuild.com. This introduces a failure ifwrapdb.mesonbuild.comgoes down, but only in the fallback path when the canonical source URL is unavailable. That seems like a worthwhile trade for the added flexibility.