Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set the mapred.job.tracker config option #27

Merged
merged 1 commit into from
Jul 19, 2014

Conversation

tarnfeld
Copy link
Member

@tarnfeld tarnfeld commented Jul 6, 2014

Configuring this option causes issues with track tracker connectivity when using the HA JobTracker configuration mode. I assume the reason this option is set is due to the fact hadoop doesn't require you configure this option on the actual JobTracker, only the clients (and task trackers)?

This probably isn't the right fix, however I wanted to open up discussion. Perhaps we could only set the option if it's not currently configured on the config object?

Would appreciate any thoughts, @brndnmtthws?

Overriding this interferes with a HA jobtracker setup.
@brndnmtthws
Copy link
Member

This is interesting; I have not yet tried the HA jobtracker.

This does appear to be the "right thing" to do. I'll have to do some testing to see how this stuff works before merging.

@tarnfeld
Copy link
Member Author

@brndnmtthws Any chance we could get this merged?

@brndnmtthws
Copy link
Member

I haven't had a chance to try it. Is it sufficiently tested?

@tarnfeld
Copy link
Member Author

I'd probably say no to be honest, we've tested the failover (HA JT) thoroughly here, but i've not tested it with non-ha. Let's leave it until that happens. I'll get to work on #28 too soon, so maybe they can come together.

@brndnmtthws
Copy link
Member

I've tested, seems to work.

brndnmtthws added a commit that referenced this pull request Jul 19, 2014
Don't set the mapred.job.tracker config option
@brndnmtthws brndnmtthws merged commit be6fe12 into mesos:master Jul 19, 2014
@tarnfeld
Copy link
Member Author

Nice one.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants