revive reviveOffers

[erikdw]

@brndnmtthws introduced the invocation of _driver.reviveOffers() to allow the framework to get previously declined offers sent back to itself.

Then the call was was inadvertently removed by @dsKarthick in this refactoring change.

We should consider reintroducing it.

Note that _reviveOffers() is called every 10 seconds, since the frequency of the nimbus-core calling allSlotsAvailableForScheduling() is driven by the nimbus.monitor.freq.secs setting. This is pretty often, and much less than the default "filter seconds" of 120 seconds. I believe this means that with the default settings, we will never reach the 120 second timeout and the declined resources will be re-offered much more quickly.

[erikdw]

Note: discovered this issue while responding to #132 .

[erikdw]

@JessicaLHartog : I'm pretty sure this is obviated by the changes in PR #200 , so I'm going to assign this to you to move to its final disposition.

[JessicaLHartog]

You're right @erikdw, this is fixed in PR #200. Will close this issue once that's good to merge.

[erikdw]

Closing this per @JessicaLHartog 's comments.

[erikdw]

v0.2.4+ has this fix. For v0.1.x (storm-0.x support) we haven't done a release yet.