Add kube-dns support to docker-compose #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid breaking stdout captures
- Kubernetes on Mesos will not have any kublets running until pods or services have been created
- Added readme for mesos/docker - Added docker-compose script
- Add default test-e2e function to cluster/kube-util.sh - Add overridde test-e2e function to cluster/mesos/docker/util.sh to run in a docker container (with access to cluster IPs)
sttts
force-pushed
the
docker-compose-dns
branch
from
7f10a4d to
569dbef
Compare
Following the ubuntu cluster provider this patch add a deployAddons.sh file. It seems it's not called right now on cluster up.
sttts
force-pushed
the
docker-compose-dns
branch
from
569dbef to
f48d3ce
Compare
sttts
force-pushed
the
docker-compose-dns
branch
from
60212c6 to
ffbad05
Compare
|
/cc @karlkfi |
6 tasks
| sed -e "s/{{ pillar\['dns_server'\] }}/${DNS_SERVER_IP}/g" $KUBE_ROOT/cluster/addons/dns/skydns-svc.yaml.in > dns/skydns-svc.yaml | ||
|
|
||
| KUBECONFIG=$("${KUBE_ROOT}/cluster/kubectl.sh" config view | base64) | ||
| sed -e "s,KUBECONFIG,$KUBECONFIG," dns/skydns-secret.yaml.in > dns/skydns-secret.yaml |
There was a problem hiding this comment.
Does this actually work? When I do a kubectl config view it redacts the secrets...
$ kubectl config view
apiVersion: v1
clusters:
- cluster:
server: http://172.17.0.60:8888
name: mesos/docker
- cluster:
certificate-authority-data: REDACTED
server: https://10.245.1.2
name: vagrant
contexts:
- context:
cluster: mesos/docker
user: mesos/docker
name: mesos/docker
- context:
cluster: vagrant
user: vagrant
name: vagrant
current-context: mesos/docker
kind: Config
preferences: {}
users:
- name: vagrant
user:
client-certificate-data: REDACTED
client-key-data: REDACTED
password: vagrant
username: vagrant
There was a problem hiding this comment.
It works because the mesos/docker cluster has no authorization enabled. But I would also prefer to write out a kubeconfig with only the needed data which is the cluster.server field.
|
This PR ok to nuke? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the ubuntu cluster provider this patch adds a deployAddons.sh file.
It seems it's not called right now on cluster up.