Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove NKP-Pulse from NKP 2.14 release #3076

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

kaiwalyajoshi
Copy link
Contributor

@kaiwalyajoshi kaiwalyajoshi commented Jan 29, 2025

What problem does this PR solve?:

NKP-Pulse isn't scheduled to be released in NKP 2.14. Here we're removing all references to it before the release-2.14 branch is cut for NKP 2.14-rc.X and GA releases.

We can revert this commmit once the release-2.14 branch is cut.

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-105160

Special notes for your reviewer:

This is mainly to avoid NKP-Pulse bits from landing into the NKP 2.14 release binaries.

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@kaiwalyajoshi kaiwalyajoshi added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Jan 29, 2025
@github-actions github-actions bot added services/kommander size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 29, 2025
@mesosphere-ci mesosphere-ci added the update-licenses signals mergebot to update licenses.d2iq.yaml label Jan 29, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13038929461

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13037757331: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@kaiwalyajoshi kaiwalyajoshi merged commit b0d160e into main Feb 11, 2025
69 checks passed
@kaiwalyajoshi kaiwalyajoshi deleted the kjoshi/remove-pulse-nkp-214 branch February 11, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/kommander size/L Denotes a PR that changes 100-499 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants