fix: Reload registry TLS certificate when it is updated on the file system #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
previously approved these changes
Nov 9, 2024
jimmidyson
force-pushed
the
repository-reload-certificate
branch
3 times, most recently
from
75ac1f0 to
9e7d960
Compare
jimmidyson
force-pushed
the
repository-reload-certificate
branch
from
9e7d960 to
64d613e
Compare
jimmidyson
approved these changes
Nov 11, 2024
|
Thank you! |
Merged
jimmidyson
pushed a commit
that referenced
this pull request
Nov 11, 2024
🤖 I have created a release *beep* *boop* --- ## 1.17.0 (2024-11-11) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Add images and demo script for in-cluster registry by @jimmidyson in #801 * feat: Build with go 1.23.3 and upgrade all tools by @jimmidyson in #808 ### Fixes 🔧 * fix: Allow TLS to pull chart from OCI repository by @dlipovetsky in #804 * fix: Reload registry TLS certificate when it is updated on the file system by @dlipovetsky in #805 ## New Contributors * @dlipovetsky made their first contribution in #804 **Full Changelog**: v1.16.0...v1.17.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: mesosphere-actions-pr-bot[bot] <157582460+mesosphere-actions-pr-bot[bot]@users.noreply.github.com>
dlipovetsky
added a commit
to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix
that referenced
this pull request
Jan 25, 2025
**What problem does this PR solve?**: The helm-repository container is defaulting to the wrong mindthegap version, one that is missing an [important fix](mesosphere/mindthegap#805). **Which issue(s) this PR fixes**: Fixes https://jira.nutanix.com/browse/NCN-104087 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
dlipovetsky
added a commit
to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix
that referenced
this pull request
Jan 28, 2025
**What problem does this PR solve?**: The helm-repository container is defaulting to the wrong mindthegap version, one that is missing an [important fix](mesosphere/mindthegap#805). **Which issue(s) this PR fixes**: Fixes https://jira.nutanix.com/browse/NCN-104087 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
faiq
pushed a commit
to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix
that referenced
this pull request
Jan 28, 2025
…#1027) **What problem does this PR solve?**: The helm-repository container is defaulting to the wrong mindthegap version, one that is missing an [important fix](mesosphere/mindthegap#805). Backport of #1024 **Which issue(s) this PR fixes**: Fixes https://jira.nutanix.com/browse/NCN-104087 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> **What problem does this PR solve?**: **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch the filesystem for changes to the certificate, and reload when it is updated.
Introduces a dependency on https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/certwatcher. This does not appear to impact the executable size.
The first commit is a test. On its own, it fails. With the fix in the second commit, the test passes.
Fixes #803
(Note: This is stacked on #804)