Use testify for testing. #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair point, @lucasmichot and thank you for this PR 🙏 The verbosity of these tests is mostly my fault as I prefer to leverage stdlib over a 3rd party package if I can get away with it, but as your PR shows, the price for a little 3rd party package is a small price to pay 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the usage of testify for testing this package.
This is a known and popular testing suite for Go.
It makes the tests very easy to maintain and concise. All assertions have been simplified. The next steps (in another PR) are to mock the responses with testify.
——
This PR could ideally be merged after the move to Github Action cf. #96
—-
Cc @rfeiner @CoolGoose