Skip to content

fix accept header #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2015
Merged

fix accept header #10

merged 1 commit into from
Nov 5, 2015

Conversation

systemfreund
Copy link
Contributor

The current version causes the following exception when using openjdk 1.8.0_66:

IllegalArgumentException: Illegal character(s) in message header field: Accepts:

Stacktrace (most recent call first):

    at sun.net.www.protocol.http.HttpURLConnection.checkMessageHeader
    at sun.net.www.protocol.http.HttpURLConnection.isExternalMessageHeaderAllowed
    at sun.net.www.protocol.http.HttpURLConnection.setRequestProperty
    at sun.net.www.protocol.https.HttpsURLConnectionImpl.setRequestProperty
    at com.messagebird.MessageBirdServiceImpl.getConnection
    at com.messagebird.MessageBirdServiceImpl.getJsonData
    at com.messagebird.MessageBirdServiceImpl.sendPayLoad
    at com.messagebird.MessageBirdClient.sendMessage
openjdk version "1.8.0_66-internal"
OpenJDK Runtime Environment (build 1.8.0_66-internal-b17)
OpenJDK 64-Bit Server VM (build 25.66-b17, mixed mode)

@samwierema
Copy link
Contributor

Thanks for the pull request! All seems to look good. We'll merge this and deploy a new version to Maven Central today.

samwierema added a commit that referenced this pull request Nov 5, 2015
@samwierema samwierema merged commit 29e33d0 into messagebird:master Nov 5, 2015
denizkilic pushed a commit that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants