PHP 8.1 Deprecation fixes #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are introduced to mitigate deprecations from PHP 8.1 and to avoid the lower boundaries test of PHP 8.1 to fail due to PHPUnit resorting to the use of `$GLOBALS`. These changes are introduced before the requirement updates to allow them to be forward and backward compatible.
This changes makes the project explicitly compatible with PHP 8.1 and enables testing with that version in the CI. Additionally, the configuration and requirements of PHPUnit are updated to be fully compatible with PHP 8.1.
agustingomes
force-pushed
the
php8.1/deprecations-resolution
branch
from
642fd54
to
e75d12d
Compare
agustingomes
commented
Feb 21, 2022
| { | ||
| return [current($this->array)]; | ||
| } | ||
|
|
||
| #[\ReturnTypeWillChange] | ||
| function key() |
There was a problem hiding this comment.
Since the return type of the interface (which is mixed ) is not compatible with PHP prior to version 8, the attribute is added instead of the correct type.
|
Thank you for the updates, merging this and will prepare a release next week. |
|
awesome @CoolGoose thank you. Looking forward for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to make this library PHP 8.1 compatible while maintaining backwards compatibility.