add support for create MMS #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jostosh
reviewed
Jun 4, 2019
jostosh
reviewed
Jun 4, 2019
| @@ -110,6 +111,16 @@ def message_delete(self, id): | |||
| """Delete a message from the dashboard.""" | |||
| self.request_plain_text('messages/' + str(id), 'DELETE') | |||
|
|
|||
| def mms_create(self, originator, recipients, body, mediaUrls, subject = None, reference = None, scheduledDatetime = None): | |||
There was a problem hiding this comment.
I'm not sure where the documentation is or how explicit it may be, but there could be more info on the parameters of these methods I think. Now the user has to figure out by reading through the code what the exact format is for scheduledDatetime. Adding a small docstring here would help
There was a problem hiding this comment.
Added docstring to the function
jostosh
reviewed
Jun 4, 2019
jostosh
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions for creare mms and some other changes