Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http crate to 1.0, fix examples #28

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

quasiyoke
Copy link
Collaborator

While testing to get dav-server-rs working with a recent axum release, @themasch encountered some problems because axum was using http@1.0, while dav-server-rs was still based on http@0.2.3.

Since the 1.0 release of http brings some stability and backward compatibility promises, @themasch figured it might be worth updating to the new release so this library is ready to be used with recent releases of all the frameworks building on http.

@themasch fixed up the hyper examples (the latest hyper release dropped some QoL features which bloats the example a bit).

I've fixed the actix and warp examples by adding some compatibility code while they remain on older versions of hyper and http. Upgrade issues:

Copy link
Owner

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@messense messense merged commit d9dfc90 into messense:main Jun 17, 2024
6 checks passed
@messense messense linked an issue Jun 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http conflict with axum
3 participants