Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a symlink for llama_models #201

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Add a symlink for llama_models #201

merged 2 commits into from
Oct 27, 2024

Conversation

ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Oct 27, 2024

A much more lightweight attempt to make sure the llama-models package is "correct" -- i.e., it has an expected llama_models sub-directory. There are a few downstream workflows where the repository is merely checked out (without a corresponding pip install -e) and it is expected that from llama_models.<foo> works by just setting a PYTHONPATH.

Test Plan
Produced a package with python -m build and then installed it in a fresh conda environment.

Checked that $CONDA_PREFIX/lib/.../site-packages/llama_models contained expected package structure namely:

datatypes.py  __init__.py  llama3/  llama3_1/  llama3_2/  prompt_format.py  __pycache__/  schema_utils.py  scripts/  sku_list.py

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 27, 2024
Copy link

30 passed

Copy link
Contributor

@raghotham raghotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@ashwinb ashwinb merged commit 7fa8b3b into main Oct 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants