[Test Automation] Add schedule job as accepted job for PRs and cron jobs #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorHack
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
reviewed
Jan 28, 2025
| permissions: | ||
| pull-requests: write | ||
| defaults: | ||
| run: | ||
| shell: bash # default shell to run all steps for a given job. | ||
| runs-on: ${{ inputs.runner != '' && inputs.runner || 'llama-models-gha-runner-cpu' }} | ||
| runs-on: ${{ inputs.runner != '' && inputs.runner || github.repository_owner == 'meta-llama' && 'llama-models-gha-runner-cpu' || 'llama-models-fork-gha-runner-cpu' }} |
There was a problem hiding this comment.
can you comment what these substrings mean? why "fork"?
There was a problem hiding this comment.
Our self-hosted runners are initially set up using Cloud Terraform code. Each runner has distinct attributes, including:
- A generic label for the runner
- A specific repository URL
When testing from a fork, a separate runner is required to run independently of the main runner. This is because the forked repository URL differs from the main repository URL, and each runner can only point to one repository.
I adjusted this line so it automatically determines what name to use based on if the repository owner is meta-llama. If it is, then we use the default runner for the main repository. If not, then we use the runner that targets the fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates CI/CD testing to the schedule workflow job for PRs, manual dispatch, and cron jobs.
Test Plan