Skip to content

OutputParser -> ToolParser refactor #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2025
Merged

OutputParser -> ToolParser refactor #130

merged 5 commits into from
Feb 7, 2025

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Feb 7, 2025 •
edited
Loading

What does this PR do?

Test Plan

test with meta-llama/llama-stack-apps#166

LLAMA_STACK_BASE_URL=http://localhost:8321 pytest -v tests/client-sdk/agents/test_agents.py::test_override_system_message_behavior --inference-model "meta-llama/Llama-3.3-70B-Instruct"
image

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@yanxi0830 yanxi0830 mentioned this pull request Feb 7, 2025
Merged
5 tasks
yanxi0830
yanxi0830 commented Feb 7, 2025
View reviewed changes
@yanxi0830 yanxi0830 marked this pull request as ready for review February 7, 2025 00:48
@yanxi0830 yanxi0830 changed the title tool refactor OutputParser -> ToolParser refactor Feb 7, 2025
ehhuang
ehhuang reviewed Feb 7, 2025
View reviewed changes
yanxi0830
yanxi0830 commented Feb 7, 2025
View reviewed changes
@ehhuang
Copy link
Contributor

ehhuang commented Feb 7, 2025

LGTM! We can iterate on the ClientTool.run in the future if needed.

@yanxi0830 yanxi0830 merged commit aba9f5f into main Feb 7, 2025
2 checks passed
@yanxi0830 yanxi0830 deleted the better_tool_refactor branch February 7, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehhuang ehhuang ehhuang left review comments

@ashwinb ashwinb ashwinb approved these changes

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanxi0830 @ehhuang @ashwinb @facebook-github-bot