Skip to content

fix: React agent should be able to work with provided config #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: React agent should be able to work with provided config #146

merged 2 commits into from
Feb 21, 2025

Conversation

hardikjshah
Copy link
Contributor

passing a custom_config was failing

python -m examples.agents.react_agent

ehhuang
ehhuang reviewed Feb 21, 2025
View reviewed changes
@yanxi0830 yanxi0830 mentioned this pull request Feb 21, 2025
Closed
yanxi0830
yanxi0830 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@yanxi0830 yanxi0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yanxi0830 yanxi0830 merged commit 08ab5df into main Feb 21, 2025
2 checks passed
@yanxi0830 yanxi0830 deleted the fix_react branch February 21, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehhuang ehhuang ehhuang left review comments

@yanxi0830 yanxi0830 yanxi0830 approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hardikjshah @ehhuang @yanxi0830 @facebook-github-bot