Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(telemetry): use zero-width space to avoid clutter #1754

Merged
merged 2 commits into from
Mar 21, 2025
Merged

feat(telemetry): use zero-width space to avoid clutter #1754

merged 2 commits into from
Mar 21, 2025

Conversation

ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Mar 21, 2025 •
edited
Loading

What does this PR do?

Before
image

Note the redundant 'llama-stack' in front of every span

Test Plan

image

ehhuang added 2 commits March 21, 2025 10:34
@ehhuang
feat(telemetry): normalize path for library client
a316166 
# What does this PR do?


## Test Plan
@ehhuang
feat(telemetry): use zero-width space to avoid clutter
73c52a7 
# What does this PR do?


## Test Plan
@ehhuang ehhuang mentioned this pull request Mar 21, 2025
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 21, 2025
@ehhuang ehhuang marked this pull request as ready for review March 21, 2025 18:31
hardikjshah
hardikjshah approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@hardikjshah hardikjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is service name even required to be an env variable ? Can it be hardcoded and not be a config that we have the same thing copied in 20+ files ?

@ehhuang ehhuang merged commit 34f89bf into meta-llama:main Mar 21, 2025
14 checks passed
@ehhuang
Copy link
Contributor Author

ehhuang commented Mar 21, 2025 •
edited
Loading

Is service name even required to be an env variable ? Can it be hardcoded and not be a config that we have the same thing copied in 20+ files ?

Yea, I think we can just remove. #1755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikjshah hardikjshah hardikjshah approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@SLR722 SLR722 Awaiting requested review from SLR722 SLR722 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehhuang @hardikjshah @facebook-github-bot