Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify host.docker.internal works for recent podman #977

Merged
merged 1 commit into from
Feb 6, 2025
Merged

docs: clarify host.docker.internal works for recent podman #977

merged 1 commit into from
Feb 6, 2025

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Feb 5, 2025

The host.docker.internal alias was implemented in podman 4.7.0:

containers/podman@b672ddc

Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com

What does this PR do?

Follow-up to previous podman specific doc update.

Test Plan

Please describe:

  • tests you ran to verify your changes with result summaries.
  • provide instructions so it can be reproduced.

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@booxter
docs: clarify host.docker.internal works for recent podman
a56b25c 
The host.docker.internal alias was implemented in podman 4.7.0:

containers/podman@b672ddc

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 5, 2025
hardikjshah
hardikjshah approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@hardikjshah hardikjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

@hardikjshah hardikjshah merged commit f4343f7 into meta-llama:main Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikjshah hardikjshah hardikjshah approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@booxter @hardikjshah @facebook-github-bot