chore: update return type to Optional[str] #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721 and
ehhuang
as code owners
facebook-github-bot
added
the
CLA Signed
booxter
reviewed
Feb 6, 2025
| @@ -57,13 +57,13 @@ def __init__(self, model_aliases: List[ModelAlias]): | |||
| self.alias_to_provider_id_map[alias_obj.llama_model] = alias_obj.provider_model_id | |||
| self.provider_id_to_llama_model_map[alias_obj.provider_model_id] = alias_obj.llama_model | |||
|
|
|||
| def get_provider_model_id(self, identifier: str) -> str: | |||
| def get_provider_model_id(self, identifier: str) -> Optional[str]: | |||
| if identifier in self.alias_to_provider_id_map: | |||
There was a problem hiding this comment.
whole thing could be just self.alias_to_provider_id_map.get(identifier, None) I think.
There was a problem hiding this comment.
Thanks for the suggestion! @ashwinb PTAL
booxter
approved these changes
Feb 6, 2025
Updated the return type of the methods `get_provider_model_id` and `get_llama_model` in the `ModelRegistryHelper` class to `Optional[str]` to indicate that they may return a string or None when no match is found. This change improves the clarity of the methods' behavior and supports better type safety. Replaced explicit `if-else` checks with `dict.get()` for cleaner code. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
add-optional-str
branch
from
b3fa9ae to
787e78d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated the return type of the methods
get_provider_model_idandget_llama_modelin theModelRegistryHelperclass toOptional[str]to indicate that they may return a string or None when no match is found. This change improves the clarity of the methods' behavior and supports better type safety.Signed-off-by: Sébastien Han seb@redhat.com
Test Plan
Please describe:
Sources
Please link relevant resources if necessary.
Before submitting
Pull Request section?