Make it easier to see when redistributions happen in get_log #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation of
get_log, finding the src placement corresponding to a given redistribution cost was annoying, as it required looking at the placement for the input node of a given operation.This lead to sometimes hard to understand costs, as situations like the following happened quite often
which could give the impression that there was a redistribution happening for the
aliasoperator asS(0) -> S(0), but in fact it's actually its input which is being redistributed fromS(1)toS(0).This PR changes the representation to add additional comment lines, which explicitly mention the src and tgt placement for every redistribution.
The new implementation looks as follows:
One drawback of the current implementation is that now we might have more lines in the file for different sharding decisions, which might make it harder to compare two sharding decisions. I might change this behavior prior to merging this PR.