Add manual constraints in Llama3 example #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation to switching the flags for enabling fusing
nn.Linearinto a single op, as well as the newadd_alias_v2flag, as well as for merging #125This is also helpful for identifying potential problems with the cost model for comms / compute.
This can also serve as an example of how users can customize precise shardings of their model, without having to change user-code. We might want to add helper ops so that this customization can happen directly in the model code as well, but I'm keeping it completely separate for now.
I've also removed the embedding constraint for 1d -- it is not needed anymore now that we have a cost model for memory-bound ops (like Embedding).