Fix class of DTypeCast wrapper module #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly always using the DTypeCastModule for all submodules in the model, which would lead to always performing the input and output casting. This should only be done at the root model
meta-cla
bot
added
the
CLA Signed
wconstab
approved these changes
Aug 1, 2025
Contributor
|
Lgtm. But out of curiosity what was the symptom you observed with this, did one of the extra casts have an observable effect? |
Contributor
Author
|
Yeah, I was seeing some fp32 casts because that's what the output_dtype is by default (I believe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly always using the DTypeCastModule for all submodules in the model, which would lead to always performing the input and output casting. This should only be done at the root model