Skip to content

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Dec 1, 2021

This is now a dependency to run the torchvision prototype tests. We are refactoring how dependencies are installed, so something like this should not happen anymore in the future.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2021
@pmeier pmeier requested a review from NivekT December 1, 2021 20:44
@pmeier
Copy link
Contributor Author

pmeier commented Dec 1, 2021

The error on Windows is unrelated. I'm currently debugging it pytorch/vision#4980.

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this.

@pmeier pmeier deleted the add-torchvision-deps branch December 2, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants