remove let_chain feature #1388
Closed
remove let_chain feature #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@cjlongoria has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83221093. |
cjlongoria
added a commit
to cjlongoria/monarch-1
that referenced
this pull request
Oct 1, 2025
Summary: let_chains were stabilized in 1.88.0 for edition 2024 and removed in 1.90.0 rust-lang/rust#132833 rust-lang/rust#143214 Reviewed By: dtolnay Differential Revision: D83221093
cjlongoria
force-pushed
the
export-D83221093
branch
from
1f8db1e to
db8c30d
Compare
Summary: let_chains were stabilized in 1.88.0 for edition 2024 and removed in 1.90.0 rust-lang/rust#132833 rust-lang/rust#143214 Reviewed By: dtolnay Differential Revision: D83221093
cjlongoria
force-pushed
the
export-D83221093
branch
from
db8c30d to
8abf15b
Compare
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Oct 1, 2025
Summary: X-link: meta-pytorch/monarch#1388 let_chains were stabilized in 1.88.0 for edition 2024 and removed in 1.90.0 rust-lang/rust#132833 rust-lang/rust#143214 Reviewed By: dtolnay Differential Revision: D83221093 fbshipit-source-id: 6fb40aa7e1c282f453394db5b7f0dab1282c2e35
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 1, 2025
Summary: X-link: meta-pytorch/monarch#1388 let_chains were stabilized in 1.88.0 for edition 2024 and removed in 1.90.0 rust-lang/rust#132833 rust-lang/rust#143214 Reviewed By: dtolnay Differential Revision: D83221093 fbshipit-source-id: 6fb40aa7e1c282f453394db5b7f0dab1282c2e35
|
This pull request has been merged in 89e00fe. |
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Oct 1, 2025
Summary: X-link: meta-pytorch/monarch#1388 let_chains were stabilized in 1.88.0 for edition 2024 and removed in 1.90.0 rust-lang/rust#132833 rust-lang/rust#143214 Reviewed By: dtolnay Differential Revision: D83221093 fbshipit-source-id: 6fb40aa7e1c282f453394db5b7f0dab1282c2e35
facebook-github-bot
pushed a commit
to facebookincubator/antlir
that referenced
this pull request
Oct 1, 2025
Summary: X-link: meta-pytorch/monarch#1388 let_chains were stabilized in 1.88.0 for edition 2024 and removed in 1.90.0 rust-lang/rust#132833 rust-lang/rust#143214 Test Plan: ci Reviewed By: dtolnay Differential Revision: D83221093 fbshipit-source-id: 6fb40aa7e1c282f453394db5b7f0dab1282c2e35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
let_chains were stabilized in 1.88.0 for edition 2024 and removed in 1.90.0
rust-lang/rust#132833
rust-lang/rust#143214
Reviewed By: dtolnay
Differential Revision: D83221093