Make lintrunner support specific to multipy

ghstack-source-id: 77a44c8
Pull Request resolved: #289

Author: PaliC

.lintbin/actionlint

@@ -1,3 +1,5 @@
+# (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary.
+
 import argparse
 import concurrent.futures
 import json
@@ -7,7 +9,6 @@
 import sys
 import time
 from enum import Enum
-from pathlib import Path
 from typing import Any, List, NamedTuple, Optional
 
 
@@ -26,15 +27,15 @@ class LintSeverity(str, Enum):
 
 
 class LintMessage(NamedTuple):
-    path: Optional[str]
+    path: str
     line: Optional[int]
     char: Optional[int]
-    code: str
     severity: LintSeverity
     name: str
     original: Optional[str]
     replacement: Optional[str]
     description: Optional[str]
+    bypassChangedLineFiltering: Optional[bool]
 
 
 def as_posix(name: str) -> str:
@@ -105,16 +106,17 @@ def check_file(
                 path=filename,
                 line=None,
                 char=None,
-                code="CLANGFORMAT",
                 severity=LintSeverity.ERROR,
                 name="timeout",
                 original=None,
                 replacement=None,
                 description=(
-                    "clang-format timed out while trying to process a file. "
-                    "Please report an issue in pytorch/pytorch with the "
-                    "label 'module: lint'"
+                    "Please report this in https://fb.workplace.com/groups/lintqa/\n"
+                    "If clang-format is timing out over a file, it can lock up "
+                    "the daily clang-format CodemodService codemods "
+                    "(see T115674339)."
                 ),
+                bypassChangedLineFiltering=None,
             )
         ]
     except (OSError, subprocess.CalledProcessError) as err:
@@ -123,7 +125,6 @@ def check_file(
                 path=filename,
                 line=None,
                 char=None,
-                code="CLANGFORMAT",
                 severity=LintSeverity.ADVICE,
                 name="command-failed",
                 original=None,
@@ -143,6 +144,7 @@ def check_file(
                         stdout=err.stdout.decode("utf-8").strip() or "(empty)",
                     )
                 ),
+                bypassChangedLineFiltering=None,
             )
         ]
 
@@ -153,14 +155,14 @@ def check_file(
     return [
         LintMessage(
             path=filename,
-            line=None,
-            char=None,
-            code="CLANGFORMAT",
+            line=1,
+            char=1,
             severity=LintSeverity.WARNING,
             name="format",
             original=original.decode("utf-8"),
             replacement=replacement.decode("utf-8"),
-            description="See https://clang.llvm.org/docs/ClangFormat.html.\nRun `lintrunner -a` to apply this patch.",
+            description="See https://fburl.com/fbsource-linters#clang-format",
+            bypassChangedLineFiltering=True,
         )
     ]
 
@@ -210,23 +212,6 @@ def main() -> None:
     )
 
     binary = os.path.normpath(args.binary) if IS_WINDOWS else args.binary
-    if not Path(binary).exists():
-        lint_message = LintMessage(
-            path=None,
-            line=None,
-            char=None,
-            code="CLANGFORMAT",
-            severity=LintSeverity.ERROR,
-            name="init-error",
-            original=None,
-            replacement=None,
-            description=(
-                f"Could not find clang-format binary at {binary}, "
-                "did you forget to run `lintrunner init`?"
-            ),
-        )
-        print(json.dumps(lint_message._asdict()), flush=True)
-        sys.exit(0)
 
     with concurrent.futures.ThreadPoolExecutor(
         max_workers=os.cpu_count(),

.lintbin/clang-format

@@ -87,7 +87,6 @@ def check_files(
     filenames: List[str],
     config: str,
     retries: int,
-    code: str,
 ) -> List[LintMessage]:
     try:
         proc = run_command(
@@ -101,7 +100,7 @@ def check_files(
                 path=None,
                 line=None,
                 char=None,
-                code=code,
+                code="MYPY",
                 severity=LintSeverity.ERROR,
                 name="command-failed",
                 original=None,
@@ -119,7 +118,7 @@ def check_files(
             char=int(match["column"])
             if match["column"] is not None and not match["column"].startswith("-")
             else None,
-            code=code,
+            code="MYPY",
             severity=severities.get(match["severity"], LintSeverity.ERROR),
             original=None,
             replacement=None,
@@ -144,11 +143,6 @@ def main() -> None:
         required=True,
         help="path to an mypy .ini config file",
     )
-    parser.add_argument(
-        "--code",
-        default="MYPY",
-        help="the code this lint should report as",
-    )
     parser.add_argument(
         "--verbose",
         action="store_true",
@@ -188,7 +182,7 @@ def main() -> None:
         else:
             filenames[filename] = True
 
-    lint_messages = check_files(list(filenames), args.config, args.retries, args.code)
+    lint_messages = check_files(list(filenames), args.config, args.retries)
     for lint_message in lint_messages:
         print(json.dumps(lint_message._asdict()), flush=True)