Make lintrunner support specific to multipy #289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
Summary: Pull Request resolved: #288 Here we copy over the lintrunner code from pytorch/pytorch and into multipy. This PR is purely here to make reviewing #289 easier. This PR should be a no-op in all respects. Test Plan: Imported from OSS Reviewed By: kurman Differential Revision: D42256287 Pulled By: PaliC fbshipit-source-id: 4f161472d0fc0804f92ba73493aff6b7741b11d5
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add lintrunner support to the repo. All linters are copied over from pytorch core. Now we can just use lintrunner to do consistent linting with internal on OSS making dev a bit easier.
The PR below this #288 is just a copy and paste of the lintrunner usage in pytorch/pytorch, so this PR only has the changes specific to multipy.
The .clang-format is also taken from pytorch core.