support for testing gloo with cuda tensors #57
+47
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
d4l3k
reviewed
Nov 14, 2025
Member
d4l3k
left a comment
d4l3k
left a comment
There was a problem hiding this comment.
Thanks for sending this! I'll kick off the tests
|
|
||
| gloo::broadcast(opts); | ||
|
|
||
| if (tensorCPU.device() != tensor.device()) { |
Member
There was a problem hiding this comment.
Why remove these checks? This is a noop if it's the same tensor?
Author
There was a problem hiding this comment.
true. i was using .clone() which was not needed. so this check can stay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54