Remove chat environment #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Khuu
requested review from
allenwang28,
ebsmothers,
felipemello1,
joecummings and
pbontrager
meta-cla
bot
added
the
CLA Signed
|
Why do we want to remove this? |
allenwang28
approved these changes
Oct 17, 2025
I don't think we're using this at all in our GRPO main Not that environments are wrong or anything like that, but I'm not sure this invocation is what we really want. I'd rather us re-design this once we have a better idea of what we want to do here |
DNXie
pushed a commit
to DNXie/forge
that referenced
this pull request
Oct 20, 2025
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guillotine falls
As titled. Removing unused environment folder (which contained just chat)