Skip to content

Enable RDMA by default #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2025
Merged

Enable RDMA by default #461

merged 2 commits into from
Oct 17, 2025

Conversation

@allenwang28
Copy link
Contributor

  • Sets the default RDMA_ENABLED to 1 (which torchstore does already)
  • Switches use_dcp to use TorchStore's rdma_available

Tested at: https://wandb.ai/cabernet-team/grpo-training/runs/y24k1l2l

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2025
@allenwang28 allenwang28 requested a review from casteryh October 17, 2025 22:46
casteryh
casteryh approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@casteryh casteryh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@casteryh
Copy link
Contributor

casteryh commented Oct 17, 2025 •
edited
Loading

lgtm, can you run it can see if it's actually using rdma (e.g. by looking at if dcp checkpoint exists and weight update time).

The run you shared 404'd for me but I trust you lol

@allenwang28 allenwang28 merged commit 6f4d3da into meta-pytorch:main Oct 17, 2025
8 of 9 checks passed
@allenwang28 allenwang28 deleted the rdma_enabled branch October 17, 2025 23:05
DNXie pushed a commit to DNXie/forge that referenced this pull request Oct 20, 2025
@allenwang28 @DNXie
Enable RDMA by default (meta-pytorch#461)
36dc45c
photomz pushed a commit to photomz/forge that referenced this pull request Oct 25, 2025
@allenwang28
Enable RDMA by default (meta-pytorch#461)
6ebe50d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casteryh casteryh casteryh approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allenwang28 @casteryh