Skip to content

fix variable assignment in DTensor emb lookup #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix variable assignment in DTensor emb lookup #2169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions torchrec/distributed/embedding_lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,18 @@ def _load_state_dict(
dst_local_shard.tensor.detach().copy_(src_local_shard.tensor)
elif isinstance(dst_param, DTensor):
assert isinstance(src_param, DTensor)
dst_param = dst_param.to_local()
src_param = src_param.to_local()
assert len(dst_param.local_chunks) == len( # pyre-ignore[16]
src_param.local_chunks
assert len(dst_param.to_local().local_chunks) == len( # pyre-ignore[16]
src_param.to_local().local_chunks
)
for dst_local_shard, src_local_shard in zip(
dst_param.to_local().local_shards(), # pyre-ignore[16]
src_param.to_local().local_shards(),
for i, (dst_local_shard, src_local_shard) in enumerate(
zip(
dst_param.to_local().local_shards(), # pyre-ignore[16]
src_param.to_local().local_shards(),
)
):
assert (
dst_local_shard.metadata.local_chunks
== src_local_shard.metadata.local_chunks
dst_param.to_local().local_chunks[i]
== src_param.to_local().local_chunks[i]
)
dst_local_shard.detach().copy_(src_local_shard)
else:
Expand Down