Add validation logic for lengths & offsets of KJT #2963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71531326 |
Summary:
This diff adds validation logic for lengths and offsets of `KeyedJaggedTensor`. The changes include:
- Add a new library `jagged_tensor_validator` and a new test file `test_jagged_tensor_validator.py`.
- The `validate_keyed_jagged_tensor` function checks the input lengths and/or offsets are valid in non-VBE case, including:
- At least one of lengths or offsets is provided
- If both are provided, they are consistent with each other
- The dimensions of these tensors align with the values tensor
- Generates test cases using Hypothesis to cover corner cases and ensure valid KJTs can successfully pass the validator.
More validation logic & test cases will be added in follow-up diffs.
Reviewed By: TroyGarden
Differential Revision: D71531326
|
This pull request was exported from Phabricator. Differential Revision: D71531326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds validation logic for lengths and offsets of
KeyedJaggedTensor. The changes include:jagged_tensor_validatorand a new test filetest_jagged_tensor_validator.py.validate_keyed_jagged_tensorfunction checks that at least one of lengths or offsets is provided and the input are valid.More validation logic & test cases will be added in follow-up diffs.
Reviewed By: TroyGarden
Differential Revision: D71531326