split test sharders into a separate file #3453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@TroyGarden has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84458052. |
meta-cla
bot
added
the
CLA Signed
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Oct 12, 2025
Summary: # context * refactor the overloaded test_utils.test_model.py file * split the sharder classes into a separate file Differential Revision: D84458052
TroyGarden
force-pushed
the
export-D84458052
branch
from
5336098 to
6c76391
Compare
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Oct 12, 2025
Summary: # context * refactor the overloaded test_utils.test_model.py file * split the sharder classes into a separate file Differential Revision: D84458052
TroyGarden
force-pushed
the
export-D84458052
branch
from
6c76391 to
de6d296
Compare
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Oct 13, 2025
Summary: # context * refactor the overloaded test_utils.test_model.py file * split the sharder classes into a separate file Differential Revision: D84458052
TroyGarden
force-pushed
the
export-D84458052
branch
from
de6d296 to
93c8091
Compare
Summary: Pull Request resolved: meta-pytorch#3453 # context * refactor the overloaded test_utils.test_model.py file * split the sharder classes into a separate file Differential Revision: D84458052
TroyGarden
force-pushed
the
export-D84458052
branch
from
93c8091 to
b71657a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
Differential Revision: D84458052