Skip to content

Conversation

@yifuwang
Copy link
Contributor

As title.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2022
@facebook-github-bot
Copy link
Contributor

@yifuwang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #123 (f203a8c) into main (c8c5430) will decrease coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   92.90%   92.23%   -0.68%     
==========================================
  Files          30       30              
  Lines        2523     2523              
==========================================
- Hits         2344     2327      -17     
- Misses        179      196      +17     
Impacted Files Coverage Δ
torchsnapshot/rng_state.py 100.00% <ø> (ø)
torchsnapshot/snapshot.py 98.42% <ø> (-0.64%) ⬇️
torchsnapshot/state_dict.py 100.00% <ø> (ø)
torchsnapshot/manifest_ops.py 86.30% <0.00%> (-9.59%) ⬇️
torchsnapshot/scheduler.py 93.77% <0.00%> (-2.23%) ⬇️
torchsnapshot/flatten.py 91.66% <0.00%> (-1.05%) ⬇️
torchsnapshot/io_preparers/tensor.py 90.00% <0.00%> (-0.63%) ⬇️
torchsnapshot/batcher.py 91.17% <0.00%> (-0.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

storage_options: Additional keyword options for the StoragePlugin to use.
See each StoragePlugin's documentation for customizations.
app_state (Dict[str, Stateful]): The application state to persist.
It take the form of a dictionary, with the keys being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/take/takes

of :meth:`Snapshot.take`. If none, the default process group will
be used.
replicated (List[str], optional): Glob patterns for marking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have examples of what this looks like?

@facebook-github-bot
Copy link
Contributor

@yifuwang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants