Fix distributed GRPO Recipe #2934
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
Fix trajectory concatenation: Update generate_trajectory_batched to properly handle the 'answers' field which is a list of strings, not a tensor.
Update reward function signature: Modify batched_rewards call to include device parameter and handle multiple reward functions properly.
Add missing fields to GRPOTrajectory: Add rewards and successes fields to the GRPOTrajectory NamedTuple and update docstring.
Fix GRPOStats concatenation: Update the concatenation logic in the training loop to properly handle the metadata field.
Fix reward indexing: Correct the answer indexing in batched_rewards function from answers[b][g] to answers[b].
These changes ensure that distributed GRPO training works correctly with proper trajectory handling and reward computation.
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testUX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example