Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selecting Cargo features #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/bitbake.template
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ S = "${{WORKDIR}}/git"
CARGO_SRC_DIR = "{project_rel_dir}"
{git_srcpv}

{features}

# please note if you have entries that do not begin with crate://
# you must change them to how that package can be fetched
SRC_URI += " \
Expand Down
2 changes: 1 addition & 1 deletion src/git.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ pub fn git_to_yocto_git_url(url: &str, name: Option<&str>, prefix: GitPrefix) ->
// check if its a git@github.com:cardoe/cargo-bitbake.git style URL
// and fix it up if it is
let fixed_url = if SSH_STYLE_REMOTE.is_match(url) {
format!("ssh://{}", url.replace(":", "/"))
format!("ssh://{}", url.replace(':', "/"))
} else {
url.to_string()
};
Expand Down
39 changes: 38 additions & 1 deletion src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,16 @@ struct Args {
/// Legacy Overrides: Use legacy override syntax
#[structopt(short = "l", long = "--legacy-overrides")]
legacy_overrides: bool,

/// Space or comma separated list of Cargo features to activate
#[structopt(long = "--features")]
features: Option<String>,
/// Activate all available Cargo features
#[structopt(long = "--all-features")]
all_features: bool,
/// Do not activate the Cargo `default` features
#[structopt(long = "--no-default-features")]
no_default_features: bool,
}

#[derive(StructOpt, Debug)]
Expand Down Expand Up @@ -299,7 +309,7 @@ fn real_main(options: Args, config: &mut Config) -> CliResult {
println!("No package.description set in your Cargo.toml, using package.name");
package.name()
},
|s| cargo::util::interning::InternedString::new(&s.trim().replace("\n", " \\\n")),
|s| cargo::util::interning::InternedString::new(&s.trim().replace('\n', " \\\n")),
);

// package homepage (or source code location)
Expand Down Expand Up @@ -401,6 +411,7 @@ fn real_main(options: Args, config: &mut Config) -> CliResult {
project_src_uri = project_repo.uri,
project_src_rev = project_repo.rev,
git_srcpv = git_srcpv,
features = feature_variable_assignments(&options).join("\n"),
cargo_bitbake_ver = env!("CARGO_PKG_VERSION"),
)
.map_err(|e| anyhow!("Unable to write to bitbake recipe file with: {}", e))?;
Expand All @@ -409,3 +420,29 @@ fn real_main(options: Args, config: &mut Config) -> CliResult {

Ok(())
}

/// Returns a vector of variable assignments for the feature selection given
/// through `options`. This vector may come in handy for not generating many
/// empty lines in the actual output in case that no feature selection is made
/// at all.
///
/// # Arguments
///
/// * `options` - The program arguments with the current feature selection
fn feature_variable_assignments(options: &Args) -> Vec<String> {
let mut output = Vec::new();

if let Some(features) = &options.features {
output.push(format!("CARGO_FEATURES = \"{}\"", features));
}

if options.all_features {
output.push(String::from("CARGO_ALL_FEATURES = \"1\""));
}

if options.no_default_features {
output.push(String::from("CARGO_NO_DEFAULT_FEATURES = \"1\""));
}

output
}