feat(Relationship Types): Relationship Types Editor and Relationship Types Page #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Nice work again :)
Looking quite good already !
I like the way it looks and the way it works.
I do have some suggestions, having played with the tools in test and given it some thought.
My main thoughts are:
- the relationship type page is super useful and should not be limited to admins
- admins should have extra options on that page though, such as the edit button…
- …and an "add new relationship" button as well on that same page? We probably don't need the "Relationship Type Editor" button in the menu in that case.
- Hard as it may be to implement, the relationship type matrix MusicBrainz has (https://musicbrainz.org/relationships) is a good visualization for the top-most level with all the relationships, rather than a long list. Alternatively, sorting and separating relationships by source entity type into separate sections with a small header could work for now since we don't have a ton of relationships.
kellnerd
reviewed
Aug 2, 2023
MonkeyDo
requested changes
Aug 16, 2023
src/client/containers/layout.js
Outdated
| const relationshipTypeEditorOptions = ( | ||
| <> | ||
| <NavDropdown.Item href="/relationship-type/create"> | ||
| Relationship Type Editor |
There was a problem hiding this comment.
OK, I've got it now.
Having thought about it some more, this link should probably be called "Create relationship type" instead and have this icon combination:
What do you think, does that make more sense?
For the layered icon:
https://codepen.io/Monkeyyyy/pen/VwVgpYQ
the-good-boy
commented
Aug 16, 2023
MonkeyDo
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Relationship Type Editor
This PR adds a Relationship Type Editor that allows us to add new relationship types and edit existing ones.
You can also add a parent relationship type using a Parent Type Modal:
You can also add pre-defined attributes to relationships:
Relationship Types Page
This PR also adds a Relationship Types page, which allows us to view and then edit existing relationship types.
This Page follows a tree type structure similar to what we have in MB.
Other
The Privilege Dropdown has some more options now. Link for admin logs page has also been moved here: