Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-749: Links that include "https://" as part of the non-protocol of the URL in Annotations break. #1008

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

architbaurai
Copy link
Contributor

Problem

BB-749: Links that include "https://" as part of the non-protocol of the URL in Annotations break.

Solution

Modified urlRegex regular expression.

Areas of Impact

The changes were reflected in src/client/helpers/utils.tsx

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! 🚀

And sorry it took me so long to get to reviewing your PR 😓

@MonkeyDo MonkeyDo merged commit dde20d9 into metabrainz:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants