fix(edition) : Cannot read property 'year' of undefined #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabalsingh24
commented
Jan 21, 2020
| @@ -339,7 +339,7 @@ function transformNewForm(data) { | |||
| ); | |||
|
|
|||
| let releaseEvents = []; | |||
| if (data.editionSection.releaseDate.year) { | |||
| if (data.editionSection.releaseDate && data.editionSection.releaseDate.year) { | |||
There was a problem hiding this comment.
I think this would've worked also if(data.edition.releaseData){.. because year is an empty string by default and will always be present.
But I think it's better to be safe :)
There was a problem hiding this comment.
Indeed. I think also if by any chance you get something other than a {year,month,day} object (like a date string), calling dateObjectToISOString with it will throw an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://tickets.metabrainz.org/browse/BB-395
Cannot read property 'year' of undefined
Solution
Now it checks if data.editionSection.releaseDate exists or not
Areas of Impact