-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(UF) : Add frontend for unified form #850
Conversation
Causing some issues with the actions, also not required. Updated node engine version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so awesome to see the feature getting so well set up !
You're doing a great job !
I commented on lots of details, which we would expect for such a big PR 😄
For now I didn't review the tests (by the way, also awesome to see the long overdue test harness for the front-end!), I figured we should start with that for now.
On my side i feel like I'm failing you a bit by not having thought through an important aspect.
I know it is very late in the game for this comment, but here it is: In view of some of the added complications of having these entity stubs (new entites created with modals) to deal with, we could reconsider that when an entity is added through the create modal we actually submit the entity for creation at that point, like the MB editor does.
If we get a BBID back from that request we can use the BBID directly. That will avoid some state complications, removing the custom deduplication code, etc.
We would still need the save-multiple-entities route because we will be creating links between all these entities.
Please let me know how you think we could approach that.
src/client/entity-editor/annotation-section/annotation-section.js
Outdated
Show resolved
Hide resolved
import {omit} from 'lodash'; | ||
import {removeEmptyAliases} from '../../entity-editor/alias-editor/actions'; | ||
import {removeEmptyIdentifiers} from '../../entity-editor/identifier-editor/actions'; | ||
// import {validateAuthorSection} from '../../entity-editor/validators/author'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was your final outcome with the validation state? Was it still slowing down the app too much? If so we'll unfortunately have to get rid fo the commented out code (and any other code that was just for this validation feature) [a moment of silence for the fallen bits].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though after optimization this doesn't seem to cause any issue. but now i am not sure if we need validations on modal, let me know if you think we should keep the validations or not.
Hey, thanks for such a detailed review.
If i understand it correctly you meant submitting the modal directly to server and not storing entity state for later submission?
I apologize for not communicating my reasons well for current workflow properly during the proposal :. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, after another review I'm happy to get this PR merged before it grows any larger :)
We still have some details to sort out which I will write out as separate feedback, but it can all be done in separate PRs now that we have this good functioning base.
Nice work ! :)
P.S: I've also deployed the current state of the PR to test.bookbrainz.org/create as requested
front-end part of unified creation form