Feat: Improve Unified creation form #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Thank you for the valuable improvements !
I'm going to merge this PR as well as #874 so that we can continue moving forward and testing thoroughly. Currently it's tricky to know which PR solves what issue, if something is solved in one PR but not the other, etc.
I want to deploy the feature branch with both PRs merged so that I can continue thorough testing.
| <AliasRow | ||
| index={rowId} | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| key={`alias-row-${rowId}`} | ||
| languageOptions={languageOptionsForDisplay} | ||
| /> | ||
| )) | ||
| )).toArray() |
There was a problem hiding this comment.
Was this a mistake on my part when I suggested this? Did it create issues?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR for unified creation form, mainly for minor UI improvements & bug patches.