Fix(BB-538): Allow concurrent relationship edits #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were calling updateRelationshipSets with undefined instead of the array of relationships
This is for relationships that are automatically added to a form vie the use of a query parameter (for example "add work" button on an edition's page), as well as relationships that are created when merging entities
|
I'm thoroughly testing the PR locally, seems to be working in most cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reference ticket BB-538
Since we use old relationship items to generate the difference array of allRemovedItems & allAddedItems, this cause issue where we don't have updated rel items.
Solution
We can just use two new attributes on rel to track removed and added items, this will ensure difference array is independent of old rel items.
Since Orm function need some changes to support this workflow, i will be creating similar PR there.
Edit: PR
Tasks