chore: Update redis package to v4 #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use 'legacyMode' in order to play well with the connect-redis package (which links Express sessions to Redis). This also means we don't need to change the structure of the createClient args object. See https://github.com/redis/node-redis/blob/redis%404.0.0/packages/client/CHANGELOG.md
leftmostcat
approved these changes
Feb 25, 2023
|
Thanks for the sanity check @leftmostcat ! |
MonkeyDo
added a commit
that referenced
this pull request
Mar 3, 2023
Changed it in the API main entry but not in the website's… See #932
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use 'legacyMode' in order to play well with the connect-redis package (which links ExpressJS sessions to Redis). This also means we don't need to change the structure of the
createClientargs object. See tj/connect-redis#337 (comment)Also of interest, the redis package changelog: https://github.com/redis/node-redis/blob/redis%404.0.0/packages/client/CHANGELOG.md