-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB-714: Fix search results page on Safari #987
BB-714: Fix search results page on Safari #987
Conversation
@MonkeyDo there were some other tables that were using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think this should all be done using the width attribute rather than inline style, as suggested in the ticket:
<tr width="16%">
instead of <tr style="width:16%">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks a whole lot better already!
I did a bit of testing after putting the PR up on test.bookbrainz, and found the profile page looking like this:
Not sure what's happening there but I'll leave it with you to investigate.
If you need help testing with Safari I can help out (otherwise there's also BrowserStack that I sometimes use for browser testing)
@MonkeyDo this should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you !
BB-714
Problem
The width of tables on the Webkit-based browser are broken.
The width of the columns is defined using Bootstrap CSS classes, which is not working on Webkit.
Solution
Setting the column sizes using the width attribute in percentages solves the issue.
Areas of Impact
All tables rendered on the Bookbrainz website that use the
col-md
class name to specify the width.