Remove containers after tests complete #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving containers up after tests is annoying and consumes memory unnecessarily so remove those after tests have run. Also, Take care to exit with correct code after removing containers.
This comment has been minimized.
This comment has been minimized.
|
Tested locally by adding a failing test and ensuring return code was non-zero. |
|
This looks OK, but it does have the effect of making repetitive tests take longer (as it means that the db needs to start up and shut down each time). Perhaps we should eventually replace it with something like the test.sh we have in LB (which allows you to bring up test containers once manually, and then take them down when you're done). |
Running test.sh without any args will build, test, and bring down db containers. Running with -u will build and bring up db containers, and subsequent runs of the script with no args will run tests without bringing down containers, allowing for iterative development. test.sh -d will bring down containers.
|
@amCap1712 I've updated the test script to copy the LB style, if the CI tests succeed then we can go ahead and merge this. |
This comment has been minimized.
This comment has been minimized.
|
ah, looks like we run the build/test steps manually in order to publish the results file, so everything works with CI, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving containers up after tests is annoying and consumes memory unnecessarily so remove those after tests have run. Also, Take care to exit with correct code after removing containers.